netdev - Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte alilgnment restriction for R-Car Gen3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Sep 2018 10:46:40 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     David Miller <davem@...emloft.net>,
        Magnus Damm <magnus.damm@...il.com>, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
Subject: Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte alilgnment
 restriction for R-Car Gen3

On Fri, Sep 21, 2018 at 07:14:02PM +0300, Sergei Shtylyov wrote:
> On 09/19/2018 11:06 AM, Simon Horman wrote:
> 
> > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
> > 
> > This patch sets from two descriptor to one descriptor because R-Car Gen3
> > does not have the 4 bytes alignment restriction of the transmission buffer.
> > 
> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
> > Signed-off-by: Simon Horman <horms+renesas@...ge.net.au>
> > ---
> > v2 [Simon Horman]
> > * As per review by Sergi Shtylyov
> 
>    It's Sergei or (more correctly) Sergey. :-)

Sorry, that was completely unintentional.

> 
> >   - Use reverse xmas tree for variable declarations
> >   - Use > rather than >= for conditions
> >   - Dropped unnecessary parentheses
> >   - Don't allocate memory for tx_align when it will not be used
> >   - But, kept NUM_TX_DESC_GEN[23] as I see some value in
> >     the self-documentation provided by these #defines
> [...]
> 
>    Better late than never (-:
> 
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> MBR, Sergei
>