netdev - Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180924092406.539fc54f@cakuba.netronome.com>
Date:   Mon, 24 Sep 2018 09:24:06 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     davem@...emloft.net, michael.chan@...adcom.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 9/9] devlink: Add
 Documentation/networking/devlink-params-bnxt.txt

On Mon, 24 Sep 2018 10:46:21 +0530, Vasundhara Volam wrote:
> This patch adds a new file to add information about configuration
> parameters that are supported by bnxt_en driver via devlink.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: linux-doc@...r.kernel.org
> Cc: Jiri Pirko <jiri@...lanox.com>
> Cc: Michael Chan <michael.chan@...adcom.com>
> 
> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> ---
>  Documentation/networking/devlink-params-bnxt.txt | 35 ++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/networking/devlink-params-bnxt.txt
> 
> diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt
> new file mode 100644
> index 0000000..ca7c457
> --- /dev/null
> +++ b/Documentation/networking/devlink-params-bnxt.txt
> @@ -0,0 +1,35 @@
> +enable_sriov		[DEVICE, GENERIC]
> +			Enable Single Root I/O Virtualisation (SRIOV) in
> +			the device.
> +			Type: Boolean
> +			Configuration mode: Permanent
> +
> +ignore_ari		[DEVICE, GENERIC]
> +			Ignore Alternative Routing-ID Interpretation (ARI)
> +			capability. If enabled, adapter will ignore ARI
> +			capability even when platforms has the support
> +			enabled and creates same number of partitions when
> +			platform does not support ARI.
> +			Type: Boolean
> +			Configuration mode: Permanent
> +
> +msix_vec_per_pf_max	[DEVICE, GENERIC]
> +			Provides the maximum number of MSIX interrupts that
> +			a device can create. Value is same across all
> +			physical functions (PFs) in the device.
> +			Type: u32
> +			Configuration mode: Permanent
> +
> +msix_vec_per_pf_min	[DEVICE, GENERIC]
> +			Provides the minimum number of MSIX interrupts required
> +			or the device initialization. Value is same across all
> +			physical functions (PFs) in the device.
> +			Type: u32
> +			Configuration mode: Permanent

Why duplicate the description of the generic parameters?

> +gre_ver_check		[DEVICE, DRIVER-SPECIFIC]
> +			Generic Routing Encapsulation (GRE) version check will
> +			be enabled in the device. If disabled, device skips
> +			version checking for incoming packets.
> +			Type: Boolean
> +			Configuration mode: Permanent