netdev - RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB2130115311A87CCF7D712B0FE7160@BN6PR1101MB2130.namprd11.prod.outlook.com>
Date:   Tue, 25 Sep 2018 17:19:07 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <UNGLinuxDriver@...rochip.com>,
        <steve.glendinning@...well.net>, <keescook@...omium.org>,
        <akurz@...la.de>, <hayeswang@...ltek.com>,
        <kai.heng.feng@...onical.com>, <grundler@...omium.org>,
        <zhongjiang@...wei.com>, <bigeasy@...utronix.de>,
        <ran.wang_1@....com>, <edumazet@...gle.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

Hi Florian,

> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev,
>  	if (wol->wolopts & WAKE_ARP)
>  		pdata->wol |= WAKE_ARP;
> 
> +	if (pdata->wol == 0)
> +		return -EINVAL;
> +
It will make function return when disabling WOL.
Is there other place handling this scenario?

>  	device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
> 
>  	phy_ethtool_set_wol(netdev->phydev, wol);


Thanks.
Woojung