netdev - Re: [net 1/1] tipc: fix flow control accounting for implicit connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180925.105333.2162486643048018947.davem@davemloft.net>
Date:   Tue, 25 Sep 2018 10:53:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: fix flow control accounting for implicit
 connect

From: Jon Maloy <jon.maloy@...csson.com>
Date: Tue, 25 Sep 2018 18:21:58 +0200

> From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
> 
> In the case of implicit connect message with data > 1K, the flow
> control accounting is incorrect. At this state, the socket does not
> know the peer nodes capability and falls back to legacy flow control
> by return 1, however the receiver of this message will perform the
> new block accounting. This leads to a slack and eventually traffic
> disturbance.
> 
> In this commit, we perform tipc_node_get_capabilities() at implicit
> connect and perform accounting based on the peer's capability.
> 
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied and queued up for -stable, thank you.