netdev - RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB213010C5A5C888C539A9938EE7160@BN6PR1101MB2130.namprd11.prod.outlook.com>
Date:   Tue, 25 Sep 2018 22:32:24 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <UNGLinuxDriver@...rochip.com>,
        <steve.glendinning@...well.net>, <keescook@...omium.org>,
        <akurz@...la.de>, <hayeswang@...ltek.com>,
        <kai.heng.feng@...onical.com>, <grundler@...omium.org>,
        <zhongjiang@...wei.com>, <bigeasy@...utronix.de>,
        <ran.wang_1@....com>, <edumazet@...gle.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

Hi Florian,

> @@ -1401,19 +1401,10 @@ static int lan78xx_set_wol(struct net_device
...
> +       if (pdata->wol & ~WAKE_ALL)
> +               return -EINVAL;
If I understand correctly, it needs to check againt "wol->wolopts" than pdata->wol.

> +
> +       pdata->wol = wol->wolopts;

Thanks.
Woojung