lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 25 Sep 2018 09:00:35 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Michal Simek <michal.simek@...inx.com>,
        <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
        "Edgar E. Iglesias" <edgar.iglesias@...inx.com>
CC:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Claudiu Beznea - M18063 <Claudiu.Beznea@...rochip.com>
Subject: Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not
 detected

On 25/09/2018 at 08:32, Michal Simek wrote:
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks Michal. Best regards,
   Nicolas

> ---
> 
> Changes in v2:
> - Clean reg at the first place - Edgar
> - Update commit message
> 
>   drivers/net/ethernet/cadence/macb_main.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 16e4ef7d7185..ed8a5c53467e 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -2160,6 +2160,7 @@ static void macb_configure_dma(struct macb *bp)
>   		else
>   			dmacfg &= ~GEM_BIT(TXCOEN);
>   
> +		dmacfg &= ~GEM_BIT(ADDR64);
>   #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>   		if (bp->hw_dma_cap & HW_DMA_CAP_64B)
>   			dmacfg |= GEM_BIT(ADDR64);
> 


-- 
Nicolas Ferre

Powered by blists - more mailing lists