netdev - Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180925084028.c7ci7nc43ss2e2wj@verge.net.au>
Date:   Tue, 25 Sep 2018 10:40:28 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a
 supported link mode

On Fri, Sep 21, 2018 at 03:01:44PM +0200, Andrew Lunn wrote:
> > Thanks Andrew,
> > 
> > it seems that removing Aysm Pause does the trick.
> 
> Great.
> 
> I will submit the patch today.
> 
> I see two possible followups:
> 
> 1) Figure out why auto-neg does not complete when Pause is
> advertised. Is this a problem with the local PHY or the link partner?
> The Micrel we have some control over, but the link partner in the
> switch we have to treat as a black box.

I may have limited scope to configure the link partner,
but it will be limited at best.

> 2) If we can get negotiation to work correctly, then implement Pause
> in the MAC driver. When phylib calls the adjust_link callback
> phydev->pause and phydev->asym_pause tells you want the partner can
> do. You can then decide how to program the MAC. There is also a
> get/set for ethtool.
> 
> It really requires somebody with the hardware to do this.

I have the hardware but I'm not sure how easily I can get
it to others.