netdev - Re: [net 1/1] tipc: lock wakeup & inputq at tipc_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180925.204929.1089099008261239921.davem@davemloft.net>
Date:   Tue, 25 Sep 2018 20:49:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: lock wakeup & inputq at tipc_link_reset()

From: Jon Maloy <jon.maloy@...csson.com>
Date: Tue, 25 Sep 2018 22:09:10 +0200

> From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
> 
> In tipc_link_reset() we copy the wakeup queue to input queue using
> skb_queue_splice_init(link->wakeupq, link->inputq).
> This is performed without holding any locks. The lists might be
> simultaneously be accessed by other cpu threads in tipc_sk_rcv(),
> something leading to to random missing packets.
> 
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.