netdev - Re: [PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487b0b66-1900-e2ac-007d-03787a55c65b@gmail.com>
Date:   Tue, 25 Sep 2018 18:52:22 -0600
From:   David Ahern <dsahern@...il.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net-ipv4: remove 2 always zero parameters from
 ipv4_update_pmtu()

On 9/25/18 6:41 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 

A summary here of which 2 parameters are always 0 would be nice.

> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  include/net/route.h             | 2 +-
>  net/ipv4/ah4.c                  | 2 +-
>  net/ipv4/esp4.c                 | 2 +-
>  net/ipv4/icmp.c                 | 2 +-
>  net/ipv4/ip_gre.c               | 2 +-
>  net/ipv4/ip_vti.c               | 2 +-
>  net/ipv4/ipcomp.c               | 2 +-
>  net/ipv4/ipip.c                 | 3 +--
>  net/ipv4/route.c                | 8 +++-----
>  net/ipv6/sit.c                  | 2 +-
>  net/netfilter/ipvs/ip_vs_core.c | 3 +--
>  net/xfrm/xfrm_interface.c       | 2 +-
>  12 files changed, 14 insertions(+), 18 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>