netdev - Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-K4wxZoNLDwba_-AEqWkN=5wz0XvW0eRrjZnDPqchhCuQ@mail.gmail.com>
Date:   Thu, 27 Sep 2018 12:42:45 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     songliubraving@...com,
        Network Development <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Willem de Bruijn <willemb@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>
Subject: Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for flow_dissector

On Thu, Sep 27, 2018 at 12:40 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
>
> On 09/27/2018 09:34 AM, Song Liu wrote:
> > Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
> > However, this is not true for test_bpf. As a result, test_bpf.ko crashes
> > the system with the following stack trace:
> >
> > This patch fixes tes_bpf by using init_net in the dummy dev.
> >
> > Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> > Reported-by: Eric Dumazet <edumazet@...gle.com>
> > Cc: Willem de Bruijn <willemb@...gle.com>
> > Cc: Petar Penkov <ppenkov@...gle.com>
> > Signed-off-by: Song Liu <songliubraving@...com>
> > ---
>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks!