netdev - Re: [PATCH net-next] net: phy: improve handling delayed work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 20:20:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: improve handling delayed work

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Mon, 24 Sep 2018 23:36:50 +0200

> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index a1f8e4816..40a7dc101 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
 ...
> @@ -635,6 +635,13 @@ int phy_speed_up(struct phy_device *phydev)
>  }
>  EXPORT_SYMBOL_GPL(phy_speed_up);
>  
> +static inline void phy_queue_state_machine(struct phy_device *phydev,
> +					   unsigned int secs)
> +{

Please do not use the inline keyword in foo.c files, let the compiler
decide.