netdev - Re: [PATCH v2 net] net: phy: sfp: Fix unregistering of HWMON SFP device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180926.202508.1046388652536435747.davem@davemloft.net>
Date:   Wed, 26 Sep 2018 20:25:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, rmk+kernel@....linux.org.uk,
        f.fainelli@...il.com
Subject: Re: [PATCH v2 net] net: phy: sfp: Fix unregistering of HWMON SFP
 device

From: Andrew Lunn <andrew@...n.ch>
Date: Tue, 25 Sep 2018 01:50:00 +0200

> A HWMON device is only registered is the SFP module supports the
> diagnostic page and is complient to SFF8472. Don't unconditionally
> unregister the hwmon device when the SFP module is remove, otherwise
> we access data structures which don't exist.
> 
> Reported-by: Florian Fainelli <f.fainelli@...il.com>
> Fixes: 1323061a018a ("net: phy: sfp: Add HWMON support for module sensors")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied.