netdev - Re: [PATCH net] vhost-vsock: fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a413a8b4-302d-7fbc-092d-95e8aa421c4c@cogentembedded.com>
Date:   Thu, 27 Sep 2018 12:52:50 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jason Wang <jasowang@...hat.com>, stefanha@...hat.com,
        mst@...hat.com
Cc:     kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] vhost-vsock: fix use after free

Hello!

On 9/27/2018 11:43 AM, Jason Wang wrote:

    Just a couple of typos...

> The access of vsock is not protected by vhost_vsock_lock. This may
> lead use after free since vhost_vsock_dev_release() may free the

   Lead to use.

> pointer at the same time.
> 
> Fix this by holding the lock during the acess.

    Access.

> Reported-by: syzbot+e3e074963495f92a89ed@...kaller.appspotmail.com
> Fixes: 16320f363ae1 ("vhost-vsock: add pkt cancel capability")
> Fixes: 433fc58e6bf2 ("VSOCK: Introduce vhost_vsock.ko")
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
[...]

MBR, Sergei