netdev - Re: [PATCH net v2 0/2] net: phy: fix WoL handling when suspending the PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97fefc19-b79f-8e75-2eae-61eb44032592@gmail.com>
Date:   Fri, 28 Sep 2018 21:41:26 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, f.fainelli@...il.com, nic_swsd@...ltek.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net v2 0/2] net: phy: fix WoL handling when suspending the
 PHY

On 27.09.2018 05:04, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@...il.com>
> Date: Mon, 24 Sep 2018 21:58:04 +0200
> 
>> phy_suspend doesn't always recognize that WoL is enabled and therefore
>> suspends the PHY when it should not. First idea to address the issue
>> was to reuse checks used in mdio_bus_phy_may_suspend which check
>> whether relevant devices are wakeup-enabled.
>> Florian raised some concerns because drivers may enable wakeup even if
>> WoL isn't enabled (e.g. certain USB network drivers).
>>
>> The new approach focuses on reducing the risk to break existing stuff.
>> We add a flag wol_enabled to struct net_device which is set in
>> ethtool_set_wol(). Then this flag is checked in phy_suspend().
>> This doesn't cover 100% of the cases yet (e.g. if WoL is enabled w/o
>> explicit configuration), but it covers the most relevant cases with
>> very little risk of regressions.
>>
>> v2:
>> - Fix a typo
> 
> Series applied, thanks.
> 
> Please deal with the extra 4 byte size of net_device in net-next.
> 
Sure. Next week I'm on travel, will do it the week after.

> Thanks.
>