netdev - Re: [net] r8169: fix network stalls due to missing bit TXCFG_AUTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a2aae48-17dc-04d2-69f3-c7bf96d5d378@gmail.com>
Date:   Fri, 28 Sep 2018 23:52:38 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tony Atkinson <tatkinson@...ux.com>,
        David Arendt <admin@...et.org>,
        Ortwin Glück <odi@....ch>
Subject: Re: [net] r8169: fix network stalls due to missing bit
 TXCFG_AUTO_FIFO

On 28.09.2018 23:47, Maciej S. Szmigiero wrote:
> On 28.09.2018 22:19, Heiner Kallweit wrote:
>> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
>> in register TxConfig. The original patch changed the order of some
>> calls resulting in these changes being overwritten by
>> rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
>> resulted in network stalls especially under high load.
>>
>> Analyzing the chip-specific hw_start functions all chip version from
>> 34, with the exception of version 39, need this bit set.
>> This patch moves setting this bit to rtl_set_tx_config_registers().
>>
>> Fixes: 4fd48c4ac0a0 ("r8169: move common initializations to tp->hw_start")
>> Reported-by: Ortwin Glück <odi@....ch>
>> Reported-by: David Arendt <admin@...et.org>
>> Tested-by: Tony Atkinson <tatkinson@...ux.com>
>> Tested-by: David Arendt <admin@...et.org>
>> Tested-by: Ortwin Glück <odi@....ch>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Please add:
> Root-caused-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> 
Sure, forgot you in the list.

Heiner

> Thanks,
> Maciej
>