netdev - Re: [PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0491255B-B4FB-42A1-9633-1AB44FFC5A52@fb.com>
Date:   Fri, 28 Sep 2018 23:22:22 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     "Justin.Lee1@...l.com" <Justin.Lee1@...l.com>,
        "joel@....id.au" <joel@....id.au>,
        "sam@...dozajonas.com" <sam@...dozajonas.com>
CC:     "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        Amithash Prasad <amithash@...com>,
        "christian@....nu" <christian@....nu>
Subject: Re: [PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow
 user space to send NC-SI command



>On 9/28/18, 11:16 AM, "Justin.Lee1@...l.com" <Justin.Lee1@...l.com> wrote:

  >  The new command (NCSI_CMD_SEND_CMD) is added to allow user space application 
  >  to send NC-SI command to the network card.
  >  Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response.
  > 
  >  The work flow is as below. 
  >  
  >  Request:
  >  User space application -> Netlink interface (msg)
                                                  -> new Netlink handler - ncsi_send_cmd_nl()
                                                  -> ncsi_xmit_cmd()
  >  Response:
  >  Response received - ncsi_rcv_rsp() -> internal response handler - ncsi_rsp_handler_xxx()
                                                                            -> ncsi_rsp_handler_netlink()
                                                                            -> ncsi_send_netlink_rsp ()
                                                                            -> Netlink interface (msg)
                                                                            -> user space application
  >  Command timeout - ncsi_request_timeout() -> ncsi_send_netlink_timeout ()
                                                                                                -> Netlink interface (msg with zero data length)
                                                                                                -> user space application
  >  Error:
  >  Error detected -> ncsi_send_netlink_err () -> Netlink interface (err msg)
                                                                                           -> user space application
    
    
    I will request to keep 2 patch, one for OEM handler and other one for netlink user space handling.