[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <vbf1s9dyhub.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Date: Fri, 28 Sep 2018 14:36:12 +0300
From: Vlad Buslov <vladbu@...lanox.com>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, jiri@...nulli.us, jhs@...atatu.com
Subject: Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()
On Thu 27 Sep 2018 at 20:42, Cong Wang <xiyou.wangcong@...il.com> wrote:
> It is clearly a copy-n-paste.
>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
> net/sched/cls_api.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 3de47e99b788..8dd7f8af6d54 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -655,7 +655,7 @@ static struct tcf_block *tcf_block_find(struct net *net, struct Qdisc **q,
>
> *q = qdisc_refcount_inc_nz(*q);
> if (!*q) {
> - NL_SET_ERR_MSG(extack, "Parent Qdisc doesn't exists");
> + NL_SET_ERR_MSG(extack, "Can't increase Qdisc refcount");
> err = -EINVAL;
> goto errout_rcu;
> }
Is there a benefit in exposing this info to user?
For all intents and purposes Qdisc is gone at that point.
Powered by blists - more mailing lists