netdev - RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB2237D7CB808A32E3173F61C4F8ED0@VI1PR0401MB2237.eurprd04.prod.outlook.com>
Date:   Sat, 29 Sep 2018 07:43:10 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

Hi all,
Sent out the v2. Please help to review.
Thanks a lot.

Hi Andrew,

> -----Original Message-----
> From: Y.b. Lu
> Sent: Friday, September 28, 2018 4:04 PM
> To: 'Andrew Lunn' <andrew@...n.ch>
> Cc: linux-kernel@...r.kernel.org; devel@...verdev.osuosl.org;
> netdev@...r.kernel.org; Richard Cochran <richardcochran@...il.com>;
> David S . Miller <davem@...emloft.net>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@....com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>
> Subject: RE: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/
> 
> Hi Andrew,
> 
> Thanks a lot for your comments.
> Please see my comments inline.
> 
> Best regards,
> Yangbo Lu
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Thursday, September 27, 2018 9:25 PM
> > To: Y.b. Lu <yangbo.lu@....com>
> > Cc: linux-kernel@...r.kernel.org; devel@...verdev.osuosl.org;
> > netdev@...r.kernel.org; Richard Cochran <richardcochran@...il.com>;
> > David S . Miller <davem@...emloft.net>; Ioana Ciocoi Radulescu
> > <ruxandra.radulescu@....com>; Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org>
> > Subject: Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of
> > staging/
> >
> > On Thu, Sep 27, 2018 at 07:12:27PM +0800, Yangbo Lu wrote:
> > > This patch is to move DPAA2 PTP driver out of staging/ since the
> > > dpaa2-eth had been moved out.
> > >
> > > Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> > > ---
[...]
> 
> > Can rtc_drv be made const?
> 
> [Y.b. Lu] Will use const in next version.
> 

[Y.b. Lu] Sorry, just found it couldn't be made const. Warnings showed when built with const.

> > Is rtc.h used by anything other than rtc.c? It seems like it can be removed.
> 
> [Y.b. Lu] Let me remove it in next version.

[Y.b. Lu] Sorry, I still kept that header file since dpaa2_phc_index need to be declared.