netdev - Re: [PATCH net-next] tls: Remove redundant vars from tls record structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180929.114158.391869595104056084.davem@davemloft.net>
Date:   Sat, 29 Sep 2018 11:41:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com, doronrk@...com
Subject: Re: [PATCH net-next] tls: Remove redundant vars from tls record
 structure

From: Vakul Garg <vakul.garg@....com>
Date: Wed, 26 Sep 2018 16:22:08 +0530

> Structure 'tls_rec' contains sg_aead_in and sg_aead_out which point
> to a aad_space and then chain scatterlists sg_plaintext_data,
> sg_encrypted_data respectively. Rather than using chained scatterlists
> for plaintext and encrypted data in aead_req, it is efficient to store
> aad_space in sg_encrypted_data and sg_plaintext_data itself in the
> first index and get rid of sg_aead_in, sg_aead_in and further chaining.
> 
> This requires increasing size of sg_encrypted_data & sg_plaintext_data
> arrarys by 1 to accommodate entry for aad_space. The code which uses
> sg_encrypted_data and sg_plaintext_data has been modified to skip first
> index as it points to aad_space.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>

Applied, thanks.