netdev - Re: [PATCH net 1/1] qlcnic: fix Tx descriptor corruption on 82xx devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180929.114713.2223247016931278384.davem@davemloft.net>
Date:   Sat, 29 Sep 2018 11:47:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shahed.shaikh@...ium.com
Cc:     netdev@...r.kernel.org, Manish.Chopra@...ium.com,
        Dept-GELinuxNICDev@...ium.com
Subject: Re: [PATCH net 1/1] qlcnic: fix Tx descriptor corruption on 82xx
 devices

From: Shahed Shaikh <shahed.shaikh@...ium.com>
Date: Wed, 26 Sep 2018 12:41:10 -0700

> In regular NIC transmission flow, driver always configures MAC using
> Tx queue zero descriptor as a part of MAC learning flow.
> But with multi Tx queue supported NIC, regular transmission can occur on
> any non-zero Tx queue and from that context it uses
> Tx queue zero descriptor to configure MAC, at the same time TX queue
> zero could be used by another CPU for regular transmission
> which could lead to Tx queue zero descriptor corruption and cause FW
> abort.
> 
> This patch fixes this in such a way that driver always configures
> learned MAC address from the same Tx queue which is used for
> regular transmission.
> 
> Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism")
> Signed-off-by: Shahed Shaikh <shahed.shaikh@...ium.com>

Applied and queued up for -stable.