lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Sep 2018 11:41:00 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, Maxime Chevallier <maxime.chevallier@...tlin.com> Subject: Re: [PATCH v2 net-next 7/8] net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES Hello! On 9/30/2018 12:04 AM, Andrew Lunn wrote: > The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to > support link_modes. Remove its use from xgde by replacing it with its > definition. > > Probably, the current behavior is wrong. It probably should be > ANDing not assigning. ORing, maybe? > Signed-off-by: Andrew Lunn <andrew@...n.ch> > --- > v2 > Remove unneeded () Really? :-) > --- > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index a7e03e3ecc93..151bdb629e8a 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -878,8 +878,9 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) > phy_write(phy_data->phydev, 0x04, 0x0d01); > phy_write(phy_data->phydev, 0x00, 0x9140); > > - phy_data->phydev->supported = PHY_GBIT_FEATURES; > - phy_data->phydev->advertising = phy_data->phydev->supported; > + phy_data->phydev->supported = PHY_10BT_FEATURES | > + PHY_100BT_FEATURES | > + PHY_1000BT_FEATURES; > phy_support_asym_pause(phy_data->phydev); > > netif_dbg(pdata, drv, pdata->netdev, > @@ -950,8 +951,9 @@ static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata) > reg = phy_read(phy_data->phydev, 0x00); > phy_write(phy_data->phydev, 0x00, reg & ~0x00800); > > - phy_data->phydev->supported = PHY_GBIT_FEATURES; > - phy_data->phydev->advertising = phy_data->phydev->supported; > + phy_data->phydev->supported = (PHY_10BT_FEATURES | > + PHY_100BT_FEATURES | > + PHY_1000BT_FEATURES); First time w/o parens and 2nd time with them doesn't look very consistent... > phy_support_asym_pause(phy_data->phydev); > > netif_dbg(pdata, drv, pdata->netdev, MBR, Sergei
Powered by blists - more mailing lists