lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Sep 2018 17:38:47 +0800 From: Li RongQing <roy.qing.li@...il.com> To: Stephen Hemminger <stephen@...workplumber.org> Cc: Li RongQing <lirongqing@...du.com>, netdev@...r.kernel.org Subject: Re: [PATCH][net-next] ipv6: drop container_of when convert dst to rt6_info > > I don't understand why you are doing this? It is not going to be > faster (or safer) than container_of. container_of provides the > same functionality and is safe against position of the member > in the structure. > In fact, most places are converting dst to rt6_info directly, and only few place uses container_of net/ipv6/ip6_output.c: struct rt6_info *rt = (struct rt6_info *)skb_dst(skb); net/ipv6/route.c: const struct rt6_info *rt = (struct rt6_info *)dst; -Li
Powered by blists - more mailing lists