netdev - Re: __nf_register_net_hook jump label splat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Sep 2018 19:39:30 +0200
From:   Florian Westphal <fw@...len.de>
To:     Borislav Petkov <bp@...en8.de>
Cc:     netdev@...r.kernel.org, Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        linux-kernel@...r.kernel.org
Subject: Re: __nf_register_net_hook jump label splat

Borislav Petkov <bp@...en8.de> wrote:
> Hi people,
> 
> this is something new I'm triggering with rc5 + tip/master while rc4 +
> tip/master is fine. Any ideas?

No clue.  I don't see any netfilter changes between rc4 & rc5.
I just tried to set up a bridge on rc5 with call-iptables=1
and I see no such splat.

> If I had to guess, it looks like this thing:
> 
> #ifdef HAVE_JUMP_LABEL
>         static_key_slow_inc(&nf_hooks_needed[pf][reg->hooknum]);
> #endif

Strange, these static keys have been there for years.
Any chance you could send your .config or bisect this?

Thanks.