netdev - Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-L-if688XRFgvQ+WkSDL6-obE16w+_2TJ=+V65SdDGFKA@mail.gmail.com>
Date:   Sun, 30 Sep 2018 18:00:12 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

On Sun, Sep 30, 2018 at 2:37 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy,
> do not do it.
>
> Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Argh, indeed. Thanks for fixing this, Eric.