netdev - RE: [PATCH] dpaa_eth: Remove useless declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB4008E17B1D850FDB118382C7ECEF0@AM6PR04MB4008.eurprd04.prod.outlook.com>
Date:   Mon, 1 Oct 2018 07:11:57 +0000
From:   Madalin-cristian Bucur <madalin.bucur@....com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] dpaa_eth: Remove useless declaration

> -----Original Message-----
> From: Nathan Chancellor [mailto:natechancellor@...il.com]
> Sent: Monday, October 1, 2018 7:10 AM
> To: Madalin-cristian Bucur <madalin.bucur@....com>; David S. Miller
> <davem@...emloft.net>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Nathan
> Chancellor <natechancellor@...il.com>
> Subject: [PATCH] dpaa_eth: Remove useless declaration
> 
> Clang warns:
> 
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning:
> tentative array definition assumed to have one element
> static const struct of_device_id dpaa_match[];
>                                  ^
> 1 warning generated.
> 
> Turns out that since this driver was introduced in commit 9ad1a3749333
> ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been
> unused. Remove it to silence the warning.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 84843de25c7b..6e0f47f2c8a3 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2731,8 +2731,6 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv
> *priv)
>  	return err;
>  }
> 
> -static const struct of_device_id dpaa_match[];
> -
>  static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
>  {
>  	u16 headroom;
> --
> 2.19.0

Acked-by: Madalin Bucur <madalin.bucur@....com>

Thank you