netdev - Re: [PATCH] Revert "openvswitch: Fix template leak in error cases."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPWQB7HOTM1+hDWHojEuiVLK8a9KHZzbfph6=phsLV4FcRvgGw@mail.gmail.com>
Date:   Mon, 1 Oct 2018 15:46:01 -0700
From:   Joe Stringer <joe@....org>
To:     Flavio Leitner <fbl@...hat.com>
Cc:     netfilter-devel@...r.kernel.org, netdev <netdev@...r.kernel.org>,
        ovs dev <dev@...nvswitch.org>, pravin shelar <pshelar@....org>
Subject: Re: [PATCH] Revert "openvswitch: Fix template leak in error cases."

On Fri, 28 Sep 2018 at 10:55, Flavio Leitner <fbl@...hat.com> wrote:
>
> This reverts commit 90c7afc96cbbd77f44094b5b651261968e97de67.
>
> When the commit was merged, the code used nf_ct_put() to free
> the entry, but later on commit 76644232e612 ("openvswitch: Free
> tmpl with tmpl_free.") replaced that with nf_ct_tmpl_free which
> is a more appropriate. Now the original problem is removed.
>
> Then 44d6e2f27328 ("net: Replace NF_CT_ASSERT() with WARN_ON().")
> replaced a debug assert with a WARN_ON() which is trigged now.
>
> Signed-off-by: Flavio Leitner <fbl@...hat.com>
> ---

Thanks for the cleanup.

Acked-by: Joe Stringer <joe@....org>