netdev - Re: re iproute2 - don't return error on success fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMj0wQZiCE3+qcpOq25oNZKqP81f5i0Xt0ctcUt-yvVAkQ@mail.gmail.com>
Date:   Tue, 2 Oct 2018 15:21:18 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Phil Sutter <phil@....cc>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Roi Dayan <roid@...lanox.com>
Subject: Re: re iproute2 - don't return error on success fix

On Thu, Sep 27, 2018 at 3:53 PM Phil Sutter <phil@....cc> wrote:
> On Thu, Sep 27, 2018 at 03:22:41PM +0300, Or Gerlitz wrote:
> > Something is still broken also after commit b45e300 "libnetlink: don't
> > return error on success" - when error is returned, the error code is
> > success..
> >
> > $ tc filter add dev enp33s0f0 protocol ip parent ffff: flower skip_sw
> > ip_flags nofirstfrag action drop && echo "success" || echo "failed"
> >
> > RTNETLINK answers: Operation not supported
> > success
>
> Hmm, I can't reproduce this. My HEAD is at the commit you mentioned:
>
> | % sudo ./tc/tc filter add dev d0 protocol ip parent ffff: flower skip_sw ip_flags nofirstfrag action drop
> | RTNETLINK answers: Operation not supported
> | We have an error talking to the kernel, -1
> | % echo $?
> | 2
>
> Are you sure you tested the right binary?

double checked now, seems broken on my end:

$ git log --oneline -3
b45e300 libnetlink: don't return error on success
5dc2204 testsuite: add libmnl
8804a8c Makefile: Add check target

$./tc/tc filter add dev enp33s0f0 protocol ip parent ffff: flower
skip_sw ip_flags frag action drop && echo "success" || echo "failed"
success

$ ./tc/tc filter add dev enp33s0f0 protocol ip parent ffff: flower
skip_sw ip_flags firstfrag action drop && echo "success" || echo
"failed"
RTNETLINK answers: Operation not supported
success

$ ./tc/tc filter show dev enp33s0f0 ingress
filter protocol ip pref 49152 flower chain 0
filter protocol ip pref 49152 flower chain 0 handle 0x1
  eth_type ipv4
  ip_flags frag
  skip_sw
  in_hw
        action order 1: gact action drop
         random type none pass val 0
         index 1 ref 1 bind 1