netdev - Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002125057.GE9155@lunn.ch>
Date:   Tue, 2 Oct 2018 14:50:57 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Eran Ben Elisha <eranbe@...lanox.com>
Cc:     netdev@...r.kernel.org,
        "John W. Linville" <linville@...driver.com>,
        Chris Preimesberger <chrisp@...nsition.com>,
        Neil Horman <nhorman@...driver.com>,
        Vidya Sagar Ravipati <vidya@...ulusnetworks.com>
Subject: Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at
 qsfp dump

On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote:
> Struct sff_diags can be used uninitialized at sff8636_show_dom, this
> caused the tool to show unreported fields (supports_alarms) by the lower
> level driver.
> 
> In addition, make sure the same struct is being initialized at
> sff8472_parse_eeprom function, to avoid the same issue here.
> 
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support")
> Signed-off-by: Eran Ben Elisha <eranbe@...lanox.com>

Hi Eran

Thanks for fixing both cases.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew