netdev - Re: [RFC v2 bpf-next 3/5] tools/bpf: bpftool, split the function do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002100215.70160204@cakuba.netronome.com>
Date:   Tue, 2 Oct 2018 10:02:15 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        netdev@...r.kernel.org
Subject: Re: [RFC v2 bpf-next 3/5] tools/bpf: bpftool, split the function
 do_dump()

On Tue,  2 Oct 2018 14:35:17 +0900, Prashant Bhole wrote:
> do_dump() function in bpftool/map.c has deep indentations. In order
> to reduce deep indent, let's move element printing code out of
> do_dump() into dump_map_elem() function.
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>