netdev - Re: [PATCH net] tcp/dccp: fix lockdep issue when SYN is backlogged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f44b17dc-2efe-5925-36d2-44512ce803cc@gmail.com>
Date:   Tue, 2 Oct 2018 11:25:37 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] tcp/dccp: fix lockdep issue when SYN is backlogged



On 10/01/2018 03:43 PM, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Mon,  1 Oct 2018 15:02:26 -0700

>> This patch extends what I did in commit 449809a66c1d ("tcp/dccp:
>> block BH for SYN processing") by adding an extra rcu_read_{lock|unlock}
>> pair in the paths that might be taken when processing SYN from
>> socket backlog (thus possibly in process context)
>>
>> Fixes: 06f877d613be ("tcp/dccp: fix other lockdep splats accessing ireq_opt")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Reported-by: syzbot <syzkaller@...glegroups.com>
> 
> Applied and queued up for -stable, thanks Eric.
> 

This needs a followup, timers do not imply rcu_read_lock() :/

I will send a patch, sorry for not having caught this earlier.