netdev - Re: [PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181002.155236.1859184270596107590.davem@davemloft.net>
Date:   Tue, 02 Oct 2018 15:52:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] inet: make sure to grab rcu_read_lock before using
 ireq->ireq_opt

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue,  2 Oct 2018 12:35:05 -0700

> Timer handlers do not imply rcu_read_lock(), so my recent fix
> triggered a LOCKDEP warning when SYNACK is retransmit.
> 
> Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt
> usages instead of guessing what is done by callers, since it is
> not worth the pain.
> 
> Get rid of ireq_opt_deref() helper since it hides the logic
> without real benefit, since it is now a standard rcu_dereference().
> 
> Fixes: 1ad98e9d1bdf ("tcp/dccp: fix lockdep issue when SYN is backlogged")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Eric.