netdev - Re: [PATCH net] inet: frags: rework rhashtable dismantle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJ7u+kJxWevjahYOufrqEoFaSsOVZnRy6FwnawiMZposw@mail.gmail.com>
Date:   Mon, 1 Oct 2018 18:54:55 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net] inet: frags: rework rhashtable dismantle

On Mon, Oct 1, 2018 at 5:58 PM Herbert Xu <herbert@...dor.apana.org.au> wrote:

> The walk interface was designed to handle read-only iteration
> through the hash table.  While this probably works since the
> actual freeing is delayed by RCU, it seems to be rather fragile.
>
> How about using the dead flag but instead of putting it in the
> rhashtable put it in netns_frags and have the timers check on that
> before calling rhashtable_remove?

Sure, I will send a new version, thanks.