lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 2 Oct 2018 05:20:06 +0200
From:   "Jason A. Donenfeld" <>
To:     Herbert Xu <>
Cc:     LKML <>,
        Netdev <>,
        Linux Crypto Mailing List <>,
        David Miller <>,
        Greg Kroah-Hartman <>,
        Samuel Neves <>,
        Andrew Lutomirski <>,
        Jean-Philippe Aumasson <>,
        Andy Polyakov <>,
        Thomas Gleixner <>,,
        X86 ML <>
Subject: Re: [PATCH net-next v6 04/23] zinc: ChaCha20 x86_64 implementation

Hi Herbert,

On Tue, Oct 2, 2018 at 5:18 AM Herbert Xu <> wrote:
> > size    old     new
> > ----    ----    ----
> > 0       62      52
> What is the old column? Is it the existing x86-64 implementation
> in the kernel or something else? This needs to be made clear in the
> patch description.

Good idea. I'll make that more clear.

> The same comment from the previous patch also stands here.  Please
> ensure that we only have one copy of chacha x86-64 code in the kernel.
> Either replace the existing one right here or in a follow-up patch
> in the same series.

Yes indeed this happens within this same series.


Powered by blists - more mailing lists