netdev - Re: [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181001.223428.810557942317894005.davem@davemloft.net>
Date:   Mon, 01 Oct 2018 22:34:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     jhs@...atatu.com, kaber@...sh.net, xiyou.wangcong@...il.com,
        jiri@...nulli.us, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: sched: act_ipt: check for underflow in
 __tcf_ipt_init()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Sat, 22 Sep 2018 16:46:48 +0300

> If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we
> return -EINVAL.  But we don't check whether it's smaller than
> sizeof(struct xt_entry_target) and that could lead to an out of bounds
> read.
> 
> Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.