netdev - Re: [PATCH net-next 2/2] tcp: adjust rcv zerocopy hints based on frag sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181001.223734.2202451307741205781.davem@davemloft.net>
Date:   Mon, 01 Oct 2018 22:37:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     soheil.kdev@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, soheil@...gle.com
Subject: Re: [PATCH net-next 2/2] tcp: adjust rcv zerocopy hints based on
 frag sizes

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Wed, 26 Sep 2018 16:57:04 -0400

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> When SKBs are coalesced, we can have SKBs with different
> frag sizes. Some with PAGE_SIZE and some not with PAGE_SIZE.
> Since recv_skip_hint is always set to the full SKB size,
> it can overestimate the amount that should be read using
> normal read for coalesced packets.
> 
> Change the recv_skip_hint so that it only includes the first
> frags that are not of PAGE_SIZE.
> 
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.