netdev - Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 01 Oct 2018 23:15:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com, haiyangz@...uxonhyperv.com
Cc:     netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet_info internal
 field initialization

From: Haiyang Zhang <haiyangz@...uxonhyperv.com>
Date: Fri, 28 Sep 2018 14:41:23 +0000

> From: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> The RSC feature -- a bit field "internal" was added here with total
> size unchanged:
> struct rndis_per_packet_info {
> 	u32 size;
> 	u32 type:31;
> 	u32 internal:1;
> 	u32 ppi_offset;
> };
> 
> On TX path, we put rndis msg into skb head room, which is not zeroed
> before passing to us. We do not use the "internal" field in TX path,
> but it may impact older hosts which use the entire 32 bits as "type".
> 
> To fix the bug, this patch sets the field "internal" to zero.
> 
> Fixes: c8e4eff4675f ("hv_netvsc: Add support for LRO/RSC in the vSwitch")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied.