netdev - Re: [PATCH net v2] r8169: fix network stalls due to missing bit TXCFG_AUTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 01 Oct 2018 23:29:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, tatkinson@...ux.com,
        admin@...et.org, odi@....ch
Subject: Re: [PATCH net v2] r8169: fix network stalls due to missing bit
 TXCFG_AUTO_FIFO

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 28 Sep 2018 23:51:54 +0200

> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
> in register TxConfig. The original patch changed the order of some
> calls resulting in these changes being overwritten by
> rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
> resulted in network stalls especially under high load.
> 
> Analyzing the chip-specific hw_start functions all chip version from
> 34, with the exception of version 39, need this bit set.
> This patch moves setting this bit to rtl_set_tx_config_registers().
> 
> Fixes: 4fd48c4ac0a0 ("r8169: move common initializations to tp->hw_start")
> Reported-by: Ortwin Glück <odi@....ch>
> Reported-by: David Arendt <admin@...et.org>
> Root-caused-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> Tested-by: Tony Atkinson <tatkinson@...ux.com>
> Tested-by: David Arendt <admin@...et.org>
> Tested-by: Ortwin Glück <odi@....ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> Hint for applying this change to stable:
> It may collide with 05212ba8132b ("r8169: set RxConfig after tx/rx is
> enabled for RTL8169sb/8110sb devices") which renamed
> rtl_set_rx_tx_config_registers() to rtl_set_tx_config_registers().
> ---
> v2:
> - added Maciej as root-caused-by

Applied and queued up for -stable, thanks for the backporting hints.