netdev - Re: [PATCH iproute2-next] tc: flower: expose hardware offload count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e205b2676a409c7f586f28ce1a26aa26ae119d0.camel@redhat.com>
Date:   Wed, 03 Oct 2018 18:08:11 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Vlad Buslov <vladbu@...lanox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] tc: flower: expose hardware offload count


On Wed, 2018-10-03 at 18:29 +0300, Vlad Buslov wrote:
> Recently flower classifier was updated to expose count of devices that
> filter is offloaded to. Add support to print this counter as 'in_hw_count'.
> 
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  tc/f_flower.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 59e5f572c542..cbacc664d397 100644

hello Vlad!

> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -1585,8 +1585,16 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
>  		if (flags & TCA_CLS_FLAGS_SKIP_SW)
>  			print_bool(PRINT_ANY, "skip_sw", "\n  skip_sw", true);
>  
> -		if (flags & TCA_CLS_FLAGS_IN_HW)
> +		if (flags & TCA_CLS_FLAGS_IN_HW) {
>  			print_bool(PRINT_ANY, "in_hw", "\n  in_hw", true);
> +
> +			if (tb[TCA_FLOWER_IN_HW_COUNT]) {
> +				__u32 count = rta_getattr_u32(tb[TCA_FLOWER_IN_HW_COUNT]);
> +
> +				print_uint(PRINT_ANY, "in_hw_count",
> +					   " in_hw_count %d", count);
^^ maybe using %u in the format is better?

thanks!
-- 
davide