[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20181002.221819.552910441499992415.davem@davemloft.net>
Date: Tue, 02 Oct 2018 22:18:19 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: edumazet@...gle.com
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: do not release socket ownership in
tcp_close()
From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 1 Oct 2018 23:24:26 -0700
> syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk));
> in tcp_close()
>
> While a socket is being closed, it is very possible other
> threads find it in rtnetlink dump.
>
> tcp_get_info() will acquire the socket lock for a short amount
> of time (slow = lock_sock_fast(sk)/unlock_sock_fast(sk, slow);),
> enough to trigger the warning.
>
> Fixes: 67db3e4bfbc9 ("tcp: no longer hold ehash lock while calling tcp_get_info()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
Applied.
Powered by blists - more mailing lists