netdev - Re: [PATCH net-next] IPv6 ifstats separation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16b15e54-0a3c-4ee2-dbe1-b0963df10c26@gmail.com>
Date:   Thu, 4 Oct 2018 10:26:42 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Stephen Suryaputra <ssuryaextr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] IPv6 ifstats separation



On 10/04/2018 09:40 AM, Stephen Suryaputra wrote:
> Separate IPv6 ifstats into the ones that are hit on fast path and
> the ones that aren't. The ones that are not can be removed as needed
> using sysctls.
> 
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> ---
>  include/linux/ipv6.h      |   3 +
>  include/net/if_inet6.h    |   3 +-
>  include/net/ipv6.h        |  28 ++-
>  include/net/snmp.h        |  22 +++
>  include/uapi/linux/ipv6.h |   3 +
>  include/uapi/linux/snmp.h |   3 +-
>  net/ipv6/addrconf.c       | 380 +++++++++++++++++++++++++++++++++++---
>  net/ipv6/addrconf_core.c  |   3 +-
>  net/ipv6/proc.c           |  57 +++++-
>  9 files changed, 462 insertions(+), 40 deletions(-)

This is a huge patch to review.

It certainly deserves a changelog explaining why we should even review this stuff.

What do we gain from this (huge and probably adding bugs) change exactly ???

Thanks.