netdev - RE: [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <HE1PR0402MB3323232E2FFE91E9D97A5B4EF1EB0@HE1PR0402MB3323.eurprd04.prod.outlook.com>
Date:   Fri, 5 Oct 2018 04:32:10 +0000
From:   Pankaj Bansal <pankaj.bansal@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexandru Marginean <alexandru.marginean@....com>
Subject: RE: [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven by
 a regmap device

Hi Andrew

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@...n.ch]
> Sent: Friday, October 5, 2018 8:38 AM
> To: Pankaj Bansal <pankaj.bansal@....com>
> Cc: Florian Fainelli <f.fainelli@...il.com>; netdev@...r.kernel.org;
> Alexandru Marginean <alexandru.marginean@....com>
> Subject: Re: [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven
> by a regmap device
> 
> > +i2c@...0000 {
> > +	compatible = "fsl,vf610-i2c";
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +	reg = <0x0 0x2000000 0x0 0x10000>;
> > +	interrupts = <0 34 0x4>; // Level high type
> > +	clock-names = "i2c";
> > +	clocks = <&clockgen 4 7>;
> > +	fsl-scl-gpio = <&gpio2 15 0>;
> > +	status = "okay";
> > +	/* The FPGA node */
> > +        fpga@66 {
> > +                compatible = "fsl,lx2160aqds-fpga", "fsl,fpga-qixis-i2c";
> > +		reg = <0x66>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		mdio1_mux@54 {
> > +			compatible = "mdio-mux-regmap", "mdio-mux";
> > +			mdio-parent-bus = <&emdio2>; /* MDIO bus */
> > +			reg = <0x54>;		 /* BRDCFG4 */
> > +			mux-mask = <0x07>;      /* EMI2_MDIO */
> > +
> > +			#address-cells=<1>;
> > +			#size-cells = <0>;
> > +
> > +			mdio1_ioslot1@0 {   // Slot 1
> > +				reg = <0x00>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +                                phy1@1 {
> 
> Hi Pankaj
> 
> It looks like you have tab vs space issues.

I will fix the formatting error in V2

> 
> > +                                        reg = <1>;
> > +                                        compatible = "ethernet-phy-id0210.7441";
> > +                                };
> 
> A blank line after here please.

OK

> > +                                phy1@0 {
> > +                                        reg = <0>;
> > +                                        compatible = "ethernet-phy-id0210.7441";
> > +                                };
> > +                        };
> 
> And here

Ok

> 
> > +			mdio1_ioslot2@1 {   // Slot 2
> > +				reg = <0x01>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +			};
> 
> and here.

Ok

> 
>     Andrew