netdev - Re: [PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3e6c7f9-912c-1b3b-0268-f5447af8946d@gmail.com>
Date:   Fri, 5 Oct 2018 14:09:17 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set
 nlmsg_len

On 10/4/18 3:37 PM, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> Some of the inner headers are not 4-byte aligned, so use
> NLMSG_LENGTH instead of sizeof(req) to set nlmsg_len.
> 

this patch is wrong; headers are supposed to be 4-bytes aligned.