netdev - Re: [PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181005084107.GA16936@apalos>
Date:   Fri, 5 Oct 2018 11:41:07 +0300
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, jesus.sanchez-palencia@...el.com,
        simon.fok@...systems.com
Subject: Re: [PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve
 a __s64 from a netlink msg

On Thu, Oct 04, 2018 at 04:17:07PM -0700, Vinicius Costa Gomes wrote:
> This allows signed 64-bit integers to be retrieved from a netlink
> message.
> ---
>  include/libnetlink.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/libnetlink.h b/include/libnetlink.h
> index 9d9249e6..88164975 100644
> --- a/include/libnetlink.h
> +++ b/include/libnetlink.h
> @@ -185,6 +185,13 @@ static inline __u64 rta_getattr_u64(const struct rtattr *rta)
>  	memcpy(&tmp, RTA_DATA(rta), sizeof(__u64));
>  	return tmp;
>  }
> +static inline __s64 rta_getattr_s64(const struct rtattr *rta)
> +{
> +	__s64 tmp;
> +
> +	memcpy(&tmp, RTA_DATA(rta), sizeof(__s64));
Maybe change it to sizeof(tmp)?
> +	return tmp;
> +}
>  static inline const char *rta_getattr_str(const struct rtattr *rta)
>  {
>  	return (const char *)RTA_DATA(rta);
> -- 
> 2.19.0
>