netdev - Re: [PATCH] wil6210: fix debugfs_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877eiw1wol.fsf@codeaurora.org>
Date:   Fri, 05 Oct 2018 14:04:42 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Maya Erez <merez@...eaurora.org>, <linux-wireless@...r.kernel.org>,
        <wil6210@....qualcomm.com>, <kernel-janitors@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings

YueHaibing <yuehaibing@...wei.com> writes:

> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Just out of curiosity, what kind of overhead are we talking about here?

-- 
Kalle Valo