netdev - Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b4d849f-9bd3-28aa-7a1c-ad61ab584041@gmail.com>
Date:   Fri, 5 Oct 2018 05:17:56 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, dsahern@...nel.org
Cc:     netdev@...r.kernel.org, weiwan@...gle.com, sd@...asysnail.net,
        xiyou.wangcong@...il.com, dsahern@...il.com
Subject: Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4
 and ipv6



On 10/04/2018 09:55 PM, David Miller wrote:
> From: David Ahern <dsahern@...nel.org>
> Date: Thu,  4 Oct 2018 20:07:50 -0700
> 
>> From: David Ahern <dsahern@...il.com>
>>
>> As part of the IPv6 fib info refactoring, the intent was to make metrics
>> handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy
>> led to confusion and a couple of incomplete attempts at finding and
>> fixing the resulting memory leak which was ultimately resolved by
>> ce7ea4af0838 ("ipv6: fix memory leak on dst->_metrics").
>>
>> Refactor metrics hanlding make the code really identical for v4 and v6,
>> and add a few test cases.
> 
> Looks nice, series applied, thanks David.
> 

Does not look well tested and reviewed to me.