netdev - Re: [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181006170846.GD6990@lunn.ch>
Date:   Sat, 6 Oct 2018 19:08:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>
Subject: Re: [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops
 structure

On Fri, Oct 05, 2018 at 10:25:22AM +0000, Igor Russkikh wrote:
> From: Dmitry Bezrukov <dmitry.bezrukov@...antia.com>
> 
> Implement get_drvinfo, set/get_msglevel, get_link callbacks
> 
> Signed-off-by: Dmitry Bezrukov <dmitry.bezrukov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>
> ---
>  drivers/net/usb/aqc111.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
> index 9908b0a04da6..ade2b60b4811 100644
> --- a/drivers/net/usb/aqc111.c
> +++ b/drivers/net/usb/aqc111.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/netdevice.h>
> +#include <linux/ethtool.h>
>  #include <linux/mii.h>
>  #include <linux/usb.h>
>  #include <linux/crc32.h>
> @@ -18,6 +19,9 @@
>  
>  #include "aqc111.h"
>  
> +#define DRIVER_VERSION "1.0.0.0"

Hi Igor

This is been discussed a number of times before, and i expect it to be
discussed again. Driver versions of useless. Please drop it.

> +#define DRIVER_NAME "Aquantia AQtion USB to 5GbE"

It might be nice to include the module name in here, making it easy to
link the module to the driver.

> +
>  static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value,
>  			     u16 index, u16 size, void *data, int nopm)
>  {
> @@ -170,6 +174,24 @@ static int aq_mdio_write_cmd(struct usbnet *dev, u16 value, u16 index,
>  	return aqc111_write_cmd(dev, AQ_PHY_CMD, value, index, size, data);
>  }
>  

   Andrew