netdev - Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181007192627.33nfcc27mvyqxbdy@localhost>
Date:   Sun, 7 Oct 2018 12:26:27 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, David Miller <davem@...emloft.net>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII
 time stampers.

On Sun, Oct 07, 2018 at 08:17:54PM +0200, Andrew Lunn wrote:
> > > +	if (err == -ENOENT)
> > > +		return NULL;
> > > +	else if (err)
> > > +		return ERR_PTR(err);
> > > +
> > > +	if (args.args_count >= 1)
> > > +		port = args.args[0];
> > 
> > If it's greater than one, than it is an error, and it should be flagged
> > as such.
> > 
> > The idea looks good though, should of_find_mii_timestamper() somehow be
> > made conditional to CONFIG_PTP and we should have a stub for when it is
> > disabled?
> 
> Hi Florian
> 
> There already is a stub. But register return -EOPNOTSUPP.

The stub returns NULL...

> > > +	return register_mii_timestamper(args.np, port);
> 
> So this returns EOPNOTUP

NULL...
 
> > >  static int of_mdiobus_register_phy(struct mii_bus *mdio,
> > >  				    struct device_node *child, u32 addr)
> > >  {
> > > +	struct mii_timestamper *mii_ts;
> > >  	struct phy_device *phy;
> > >  	bool is_c45;
> > >  	int rc;
> > >  	u32 phy_id;
> > >  
> > > +	mii_ts = of_find_mii_timestamper(child);
> > > +	if (IS_ERR(mii_ts))
> > > +		return PTR_ERR(mii_ts);
> > > +
> 
> and this returns EOPNOPTSUPP, so the PHY is not registered :-(

and the phydev.mii_ts field is then set to NULL.

Thanks,
Richard