netdev - Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181007102357.2kx3rve3qci4ezap@brauner.io>
Date:   Sun, 7 Oct 2018 12:23:58 +0200
From:   Christian Brauner <christian@...uner.io>
To:     David Ahern <dsahern@...il.com>
Cc:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        davem@...emloft.net, jbenc@...hat.com, stephen@...workplumber.org
Subject: Re: [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo for
 strict data checking

On Fri, Oct 05, 2018 at 01:26:31PM -0600, David Ahern wrote:
> On 10/5/18 11:54 AM, Christian Brauner wrote:
> >> +static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh,
> >> +				   struct netlink_ext_ack *extack)
> >> +{
> >> +	struct ifinfomsg *ifm;
> >> +
> >> +	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) {
> >> +		NL_SET_ERR_MSG(extack, "Invalid header");
> >> +		return -EINVAL;
> >> +	}
> >> +
> >> +	if (nlh->nlmsg_len > nlmsg_msg_size(sizeof(*ifm))) {
> > 
> > Shouldn't ipv6 specific dump requests at least support IFA_TARGET_NETNSID?
> 
> It does not today. The AF_UNSPEC GETLINK dumps it but the AF_INET6 does
> not.
> 
> Some one can add it later if desired.

Weird, I thought I had sent a patch for that as well. Doesn't matter now
I'll just send one once your branch lands. :) Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)