netdev - Re: [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddf7efb8-e7d6-fb6a-7b85-fe3c94819488@gmail.com>
Date:   Mon, 8 Oct 2018 07:25:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Christian Brauner <christian@...uner.io>,
        David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jbenc@...hat.com,
        stephen@...workplumber.org
Subject: Re: [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats_dump for
 strict data checking

On 10/8/18 4:17 AM, Christian Brauner wrote:
>> @@ -4696,13 +4697,32 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb)
>>  
>>  	cb->seq = net->dev_base_seq;
>>  
>> -	if (nlmsg_len(cb->nlh) < sizeof(*ifsm))
>> +	if (nlmsg_len(cb->nlh) < sizeof(*ifsm)) {
>> +		NL_SET_ERR_MSG(extack, "Invalid header for stats dump");
>>  		return -EINVAL;
>> +	}
>>  
>>  	ifsm = nlmsg_data(cb->nlh);
>> +
>> +	/* only requests using NLM_F_DUMP_PROPER_HDR can pass data to
> 
> That looks like an accidental leftover before we changed this to a
> socket option. :)
> 

ugh. thanks for noticing.