netdev - Re: [PATCH net-next 13/19] net: usb: aqc111: Add support for TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1539007973.10342.22.camel@suse.com>
Date:   Mon, 08 Oct 2018 16:12:53 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 13/19] net: usb: aqc111: Add support for TSO

On Fr, 2018-10-05 at 10:25 +0000, Igor Russkikh wrote:
> From: Dmitry Bezrukov <dmitry.bezrukov@...antia.com>
> 
> Signed-off-by: Dmitry Bezrukov <dmitry.bezrukov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>
> ---
>  drivers/net/usb/aqc111.c | 3 +++
>  drivers/net/usb/aqc111.h | 6 ++++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
> index 6efd9a9ad44e..f61fa7446b72 100644
> --- a/drivers/net/usb/aqc111.c
> +++ b/drivers/net/usb/aqc111.c
> @@ -964,6 +964,9 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
>  	/*Length of actual data*/
>  	tx_hdr.length = (skb->len & 0x1FFFFF);
>  
> +	/* TSO MSS */
> +	tx_hdr.max_seg_size = skb_shinfo(skb)->gso_size;

Endianness
> +
>  	headroom = (skb->len + AQ_TX_HEADER_SIZE) % 8;
>  	if (headroom != 0)
>  		padding_size = 8 - headroom;

	Regards
		Oliver